-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strong APA v1.3 #7
base: master
Are you sure you want to change the base?
Conversation
* @param thread Thread correspoding to the @node that asks for help. | ||
* @param node node associated with @thread | ||
*/ | ||
* @param scheduler The scheduler control instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space
* Finds and returns the highest ready node present by accessing the | ||
* _Strong_APA_Context->CPU with front and rear values. | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no blank line
first_task = true; | ||
|
||
|
||
//Assert rear < sizeof(Context->CPU) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
|
||
|
||
//Assert rear < sizeof(Context->CPU) | ||
_Assert( rear < CONFIGURE_MAXIMUM_PROCESSOR ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<= ?
|
||
/* | ||
* Highest ready is not just directly reachable from the victim cpu | ||
* So there is need of task shifting . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"need for" and remove space before period.
next_thread = curr_strong_node->invoker->heir; | ||
next_node = _Thread_Scheduler_get_home_node( next_thread ); | ||
|
||
while( curr_node != lowest_reachable ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ws
|
||
//Add it to All_nodes chain since it is now either scheduled or just ready. | ||
|
||
//Add it to Ready chain since it is now either scheduled or just ready. | ||
_Scheduler_strong_APA_Insert_ready(context,node,insert_priority); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ws
//Add it to All_nodes chain since it is now either scheduled or just ready. | ||
|
||
//Add it to Ready chain since it is now either scheduled or just ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* */
//Checks if the thread_CPU is in the affinity set of the node | ||
if ( _Processor_mask_Is_set( &strong_node->Affinity, cpu_index) ) { | ||
if ( _Processor_mask_Is_set( &strong_node->Affinity, cpu_index) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ws cpu_index)
@@ -839,7 +867,7 @@ void _Scheduler_strong_APA_Add_processor( | |||
idle, | |||
_Scheduler_strong_APA_Has_ready, | |||
_Scheduler_strong_APA_Enqueue_scheduled, | |||
_Scheduler_strong_APA_Register_idle | |||
_Scheduler_SMP_Do_nothing_register_idle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since now you don't use _Scheduler_strong_APA_Register_idle
you should delete its file
No description provided.